feat: add tools to interact with the app #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
Adds a suite of Appium interaction tools and integrates them into the MCP server, updates locator logic to return a single suggestion, and stubs out ID validation.
- Introduces
appium_find_element,appium_click,appium_set_value,appium_get_text, andappium_screenshottools - Registers new tools (and a test generation helper) in
src/tools/index.ts - Updates locator generator to return only the top suggestion and adds a placeholder ID checker
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/utils.ts | Stubbed out checkIsValidElementId with always-true |
| src/tools/interactions/click.ts | Adds click tool; function name mismatches export |
| src/tools/interactions/setValue.ts | Adds set-value tool |
| src/tools/interactions/getText.ts | Adds get-text tool |
| src/tools/interactions/screenshot.ts | Adds screenshot tool without parameters schema |
| src/tools/interactions/find.ts | Adds find-element tool |
| src/tools/index.ts | Registers all new tools |
| src/tools/generate-tests.ts | Adds test-generation instructions with typos |
| src/locators/locator-generation.ts | Returns only the first locator suggestion |
| examples/android-todo-app.md | Example doc with grammatical issues |
Comments suppressed due to low confidence (4)
src/tools/interactions/click.ts:7
- The function is named
generateTestbut implements a click tool. Rename it toclickElement(or similar) to match the tool's purpose and default export.
export default function generateTest(server: FastMCP): void {
src/tools/interactions/screenshot.ts:6
- This tool has no
parametersschema defined, which may lead to unexpected invocation errors. Consider addingparameters: z.object({})for clarity.
server.addTool({
examples/android-todo-app.md:1
- [nitpick] The sentence is unclear and missing articles. Consider rephrasing to: 'Use the Appium generate-test tool to create an automation test for the following steps:'
Using appium generate test tool create automation test for below step
src/locators/locator-generation.ts:209
- Changing from returning all sorted locators to only the first removes fallback options. If this is intentional, update function name or document the behavior; otherwise revert.
return [sortedLocators[0]];
| // 'Given id is not a valid element id. Call find_element_tool to fetch the correct uuid of the element' | ||
| // ); | ||
| // } | ||
| return true; |
There was a problem hiding this comment.
Validation logic in checkIsValidElementId is commented out, so all IDs pass. Consider re-enabling or removing the stubbed code to ensure proper UUID validation.
Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.